Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel Veillard
On Mon, Jan 12, 2009 at 11:17:52AM +, Mark McLoughlin wrote: > On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote: > > > + For PCI devices the element carries 3 attributes allowing to > > designate > > + the device as can be found with the lspci command, the > > + bus att

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 12:55:14PM +0100, Daniel Veillard wrote: > On Mon, Jan 12, 2009 at 11:46:38AM +, Daniel P. Berrange wrote: > > > I also noticed that we parse (and save) and extra PCI domain > > > argument, but it's not actually used when calling qemu, so I > > > assume it's a missing

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel Veillard
On Mon, Jan 12, 2009 at 11:46:38AM +, Daniel P. Berrange wrote: > > I also noticed that we parse (and save) and extra PCI domain > > argument, but it's not actually used when calling qemu, so I > > assume it's a missing feature for QEmu and just decided to patch > > the code to not save the e

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel Veillard
On Mon, Jan 12, 2009 at 11:23:51AM +, Daniel P. Berrange wrote: > On Mon, Jan 12, 2009 at 11:17:52AM +, Mark McLoughlin wrote: > > On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote: > > > > > + For PCI devices the element carries 3 attributes allowing to > > > designate > > >

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 11:30:51AM +0100, Daniel Veillard wrote: > The following add the documentation for the PCI passthrough, > extends the RNG and add an extra test for the QEmu parsing to > args and serialization back to XML. > I also noticed that we parse (and save) and extra PCI domain >

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel P. Berrange
On Mon, Jan 12, 2009 at 11:17:52AM +, Mark McLoughlin wrote: > On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote: > > > + For PCI devices the element carries 3 attributes allowing to > > designate > > + the device as can be found with the lspci command, the > > + bus att

Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Mark McLoughlin
On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote: > + For PCI devices the element carries 3 attributes allowing to designate > + the device as can be found with the lspci command, the > + bus attribute allows the hexadecimal values 0 to ff, the > + slot attribute allows

[libvirt] [PATCH] PCI passthrough docs, tests and minor change

2009-01-12 Thread Daniel Veillard
The following add the documentation for the PCI passthrough, extends the RNG and add an extra test for the QEmu parsing to args and serialization back to XML. I also noticed that we parse (and save) and extra PCI domain argument, but it's not actually used when calling qemu, so I assume it's a