Re: [libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED

2009-02-17 Thread Cole Robinson
Maximilian Wilhelm wrote: > Anno domini 2009 Cole Robinson scripsit: > >> Cole Robinson wrote: >>> Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached. > >> Pushed now. > > Nice idea, wrong function though. > Wow, I'm a dope. Sorry about that. I committed the patch on a separ

Re: [libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED

2009-02-17 Thread Maximilian Wilhelm
Anno domini 2009 Cole Robinson scripsit: > Cole Robinson wrote: > > Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached. > Pushed now. Nice idea, wrong function though. See attached patch and please git pull http://git.rfc2324.org/repositories/libvirt.git 4upstream C

Re: [libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED

2009-02-17 Thread Cole Robinson
Cole Robinson wrote: > Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached. > Pushed now. Thanks, Cole -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED

2009-02-17 Thread Daniel P. Berrange
On Mon, Feb 16, 2009 at 06:42:50PM -0500, Cole Robinson wrote: > Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached. > > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index 09be3fb..20d3c0c 100644 > --- a/src/qemu_driver.c > +++ b/src/qemu_driver.c > @@ -2883,7 +2883,7 @

Re: [libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED

2009-02-17 Thread Jim Meyering
Cole Robinson wrote: > Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached. > > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index 09be3fb..20d3c0c 100644 > --- a/src/qemu_driver.c > +++ b/src/qemu_driver.c > @@ -2883,7 +2883,7 @@ cleanup: > > > static char *qemudDomainD

[libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED

2009-02-16 Thread Cole Robinson
Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached. Thanks, Cole diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 09be3fb..20d3c0c 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2883,7 +2883,7 @@ cleanup: static char *qemudDomainDumpXML(virDomainPtr dom,