Re: [libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-18 Thread Eric Blake
On 04/18/2013 01:36 AM, Tal Kain wrote: >> >> Personally, I don't think the patch is too bad, and I'll probably apply >> it unless Dan can give a stronger objection. >> > I was wondering if there are any updates about this patch Sure, I just applied it. I shortened the subject line (generally com

Re: [libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-18 Thread Tal Kain
On Wed, Apr 10, 2013 at 1:04 AM, Eric Blake wrote: > On 04/09/2013 12:38 AM, Tal Kain wrote: > > On Mon, Apr 8, 2013 at 4:32 PM, Daniel P. Berrange >wrote: > > > >> On Mon, Apr 08, 2013 at 03:33:07PM +0300, Tal Kain wrote: > >>> Signed-off-by: Tal Kain > >>> --- > >>> src/qemu/qemu_capabilitie

Re: [libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-09 Thread Eric Blake
On 04/09/2013 12:38 AM, Tal Kain wrote: > On Mon, Apr 8, 2013 at 4:32 PM, Daniel P. Berrange wrote: > >> On Mon, Apr 08, 2013 at 03:33:07PM +0300, Tal Kain wrote: >>> Signed-off-by: Tal Kain >>> --- >>> src/qemu/qemu_capabilities.c | 13 +++-- >>> 1 file changed, 7 insertions(+), 6 del

Re: [libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-08 Thread Tal Kain
On Mon, Apr 8, 2013 at 4:32 PM, Daniel P. Berrange wrote: > On Mon, Apr 08, 2013 at 03:33:07PM +0300, Tal Kain wrote: > > Signed-off-by: Tal Kain > > --- > > src/qemu/qemu_capabilities.c | 13 +++-- > > 1 file changed, 7 insertions(+), 6 deletions(-) > > What is the motivation for doin

Re: [libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-08 Thread Daniel P. Berrange
On Mon, Apr 08, 2013 at 03:33:07PM +0300, Tal Kain wrote: > Signed-off-by: Tal Kain > --- > src/qemu/qemu_capabilities.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) What is the motivation for doing this ? it just looks like overkill to me, since virArchFromHost isn't

[libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

2013-04-08 Thread Tal Kain
Signed-off-by: Tal Kain --- src/qemu/qemu_capabilities.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 50712b0..b235059 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilitie