Re: [libvirt] [PATCH] Revert "qemu: monitor: do not report error on shutdown"

2018-01-19 Thread Michal Privoznik
On 01/19/2018 02:11 PM, Ján Tomko wrote: > On Fri, Jan 19, 2018 at 02:00:44PM +0100, Michal Privoznik wrote: >> This reverts commit aeda1b8c56dc58b0a413acc61bbea938b40499e1. >> >> Problem is that we need mon->lastError to be set because it's >> used all over the place. Also, there's nothing wrong w

[libvirt] [PATCH] Revert "qemu: monitor: do not report error on shutdown"

2018-01-19 Thread Michal Privoznik
This reverts commit aeda1b8c56dc58b0a413acc61bbea938b40499e1. Problem is that we need mon->lastError to be set because it's used all over the place. Also, there's nothing wrong with reporting error if one occurred. I mean, if there's a thread executing an API and which currently is talking on moni

Re: [libvirt] [PATCH] Revert "qemu: monitor: do not report error on shutdown"

2018-01-19 Thread Ján Tomko
On Fri, Jan 19, 2018 at 02:00:44PM +0100, Michal Privoznik wrote: This reverts commit aeda1b8c56dc58b0a413acc61bbea938b40499e1. Problem is that we need mon->lastError to be set because it's used all over the place. Also, there's nothing wrong with reporting error if one occurred. I mean, if ther