Re: [libvirt] [PATCH] Split contents of ... and set LXC init argv

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 12:00:04PM -0600, Eric Blake wrote: > On 03/14/2012 11:53 AM, Daniel P. Berrange wrote: > > > In other words, I don't think it is acceptable to automagically > > split '' and pass them as argv[]. We should only > > use it for setting LIBVIRT_LXC_CMDLINE. > > > > We should

Re: [libvirt] [PATCH] Split contents of ... and set LXC init argv

2012-03-14 Thread Eric Blake
On 03/14/2012 11:53 AM, Daniel P. Berrange wrote: > In other words, I don't think it is acceptable to automagically > split '' and pass them as argv[]. We should only > use it for setting LIBVIRT_LXC_CMDLINE. > > We should add a separate element for setting init's > argv[] I think as in: com

Re: [libvirt] [PATCH] Split contents of ... and set LXC init argv

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 11:22:35AM -0600, Eric Blake wrote: > On 03/14/2012 09:24 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Currently for LXC we set LIBVIRT_LXC_CMDLINE to contain the > > contents of It is more convenient > > if we just set the argv[] of the init b

Re: [libvirt] [PATCH] Split contents of ... and set LXC init argv

2012-03-14 Thread Eric Blake
On 03/14/2012 09:24 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Currently for LXC we set LIBVIRT_LXC_CMDLINE to contain the > contents of It is more convenient > if we just set the argv[] of the init binary directly though. > > * lxc/lxc_container.c: Set init argv from cm

[libvirt] [PATCH] Split contents of ... and set LXC init argv

2012-03-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently for LXC we set LIBVIRT_LXC_CMDLINE to contain the contents of It is more convenient if we just set the argv[] of the init binary directly though. * lxc/lxc_container.c: Set init argv from cmdline --- src/lxc/lxc_container.c | 12 1 files