Re: [libvirt] [PATCH] Support configuration of huge pages in guests

2009-09-03 Thread Daniel Veillard
On Wed, Aug 26, 2009 at 02:03:07PM +0100, Daniel P. Berrange wrote: [...] > +if (def->hugepage_backed) { > +if (!driver->hugetlbfs_mount) { > +qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, > + "%s", _("hugetlbfs filesystem is not moun

Re: [libvirt] [PATCH] Support configuration of huge pages in guests

2009-09-03 Thread Daniel P. Berrange
On Thu, Sep 03, 2009 at 11:48:53AM +0100, Mark McLoughlin wrote: > > @@ -290,10 +305,22 @@ int qemudLoadDriverConfig(struct qemud_driver *driver, > > } > > } > > > > + p = virConfGetValue (conf, "hugetlbfs_mount"); > > + CHECK_TYPE ("hugetlbfs_mount", VIR_CONF_STRING); > > +

Re: [libvirt] [PATCH] Support configuration of huge pages in guests

2009-09-03 Thread Mark McLoughlin
On Wed, 2009-08-26 at 14:03 +0100, Daniel P. Berrange wrote: I hope you're planning on adding all that useful info from the 0/1 mail to the git commit log? > * configure.in: Add check for mntent.h > * qemud/libvirtd_qemu.aug, qemud/test_libvirtd_qemu.aug, src/qemu.conf > Add 'hugetlbfs_mount' c

Re: [libvirt] [PATCH] Support configuration of huge pages in guests

2009-09-02 Thread john cooper
Daniel P. Berrange wrote: > * configure.in: Add check for mntent.h > * qemud/libvirtd_qemu.aug, qemud/test_libvirtd_qemu.aug, src/qemu.conf > Add 'hugetlbfs_mount' config parameter > * src/qemu_conf.c, src/qemu_conf.h: Check for -mem-path flag in QEMU, > and pass it when hugepages are requested

[libvirt] [PATCH] Support configuration of huge pages in guests

2009-08-26 Thread Daniel P. Berrange
* configure.in: Add check for mntent.h * qemud/libvirtd_qemu.aug, qemud/test_libvirtd_qemu.aug, src/qemu.conf Add 'hugetlbfs_mount' config parameter * src/qemu_conf.c, src/qemu_conf.h: Check for -mem-path flag in QEMU, and pass it when hugepages are requested. Load hugetlbfs_mount config para