Re: [libvirt] [PATCH] Unify *ReportError logic

2008-10-08 Thread Cole Robinson
Daniel P. Berrange wrote: > On Thu, Oct 02, 2008 at 04:12:10PM -0400, Cole Robinson wrote: >> Daniel P. Berrange wrote: >>> >>> Basically a good idea - we've discussed doing exactly this in the past. >>> You can do further though, and kill off the 'dom' and 'net' parameters >>> here too. Those are

Re: [libvirt] [PATCH] Unify *ReportError logic

2008-10-03 Thread Daniel Veillard
On Thu, Oct 02, 2008 at 08:53:12PM +0100, Daniel P. Berrange wrote: > On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote: > > Currently, most src/* files have their own ReportError > > function. Some support printf style arguments, others > > only allow reporting a single string message.

Re: [libvirt] [PATCH] Unify *ReportError logic

2008-10-03 Thread Daniel P. Berrange
On Thu, Oct 02, 2008 at 04:12:10PM -0400, Cole Robinson wrote: > Daniel P. Berrange wrote: > > On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote: > >> Currently, most src/* files have their own ReportError > >> function. Some support printf style arguments, others > >> only allow report

Re: [libvirt] [PATCH] Unify *ReportError logic

2008-10-02 Thread Cole Robinson
Daniel P. Berrange wrote: > On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote: >> Currently, most src/* files have their own ReportError >> function. Some support printf style arguments, others >> only allow reporting a single string message. The code >> for all of them does virtually t

Re: [libvirt] [PATCH] Unify *ReportError logic

2008-10-02 Thread Daniel P. Berrange
On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote: > Currently, most src/* files have their own ReportError > function. Some support printf style arguments, others > only allow reporting a single string message. The code > for all of them does virtually the same thing, possibly > passin

[libvirt] [PATCH] Unify *ReportError logic

2008-10-02 Thread Cole Robinson
Currently, most src/* files have their own ReportError function. Some support printf style arguments, others only allow reporting a single string message. The code for all of them does virtually the same thing, possibly passing a different constant off to another function. The attached patch adds