Re: [libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Stefan Berger
On 04/30/2012 12:55 PM, Daniel P. Berrange wrote: On Mon, Apr 30, 2012 at 12:42:37PM -0400, Stefan Berger wrote: > /libvirt/daemon/libvirtd.c:168: > leaked_handle: Handle variable "stdinfd" going out of scope leaks the handle. This is refering to the 3rd line here: switch

Re: [libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2012 at 12:42:37PM -0400, Stefan Berger wrote: > On 04/30/2012 12:34 PM, Daniel P. Berrange wrote: > >On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote: > >>Addressing the following reports: > >> > >None of those reports mention daemon/libvirtd.c and yet > > > > These m

Re: [libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Stefan Berger
On 04/30/2012 12:34 PM, Daniel P. Berrange wrote: On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote: Addressing the following reports: None of those reports mention daemon/libvirtd.c and yet These must have gotten lost: Error: RESOURCE_LEAK: /libvirt/daemon/libvirtd.c:147: open

Re: [libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote: > Addressing the following reports: > None of those reports mention daemon/libvirtd.c and yet > daemon/libvirtd.c | 24 +++- > Index: libvirt-acl/daemon/libvirtd.c >

[libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Stefan Berger
Addressing the following reports: Error: RESOURCE_LEAK: /libvirt/src/nodeinfo.c:631: alloc_fn: Calling allocation function "fopen". /libvirt/src/nodeinfo.c:631: var_assign: Assigning: "cpuinfo" = storage returned from "fopen("/proc/cpuinfo", "r")". /libvirt/src/nodeinfo.c:640: leaked_storage: