Re: [libvirt] [PATCH] bhyve: bhyveDomainDefineXML fixes

2014-04-23 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Mon, Apr 21, 2014 at 08:22:23PM +0400, Roman Bogorodskiy wrote: > > - do not loose new definition for an active domain > > - do not leak oldDef > > - do not set dom->id if virDomainSaveConfig() fails > > - do not call virObjectUnlock(vm) if vm is NULL > > --- > >

Re: [libvirt] [PATCH] bhyve: bhyveDomainDefineXML fixes

2014-04-23 Thread Daniel P. Berrange
On Mon, Apr 21, 2014 at 08:22:23PM +0400, Roman Bogorodskiy wrote: > - do not loose new definition for an active domain > - do not leak oldDef > - do not set dom->id if virDomainSaveConfig() fails > - do not call virObjectUnlock(vm) if vm is NULL > --- > src/bhyve/bhyve_driver.c | 14 ++---

[libvirt] [PATCH] bhyve: bhyveDomainDefineXML fixes

2014-04-21 Thread Roman Bogorodskiy
- do not loose new definition for an active domain - do not leak oldDef - do not set dom->id if virDomainSaveConfig() fails - do not call virObjectUnlock(vm) if vm is NULL --- src/bhyve/bhyve_driver.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/bhyve/bhy