Re: [libvirt] [PATCH] build: avoid non-portable cast of pthread_t

2013-05-03 Thread Eric Blake
On 05/03/2013 02:58 AM, Daniel P. Berrange wrote: > On Thu, May 02, 2013 at 03:58:23PM -0600, Eric Blake wrote: >> POSIX says pthread_t is opaque. We can't guarantee if it is scaler >> or a pointer, nor what size it is; and BSD differs from Linux. >> We've also had reports of gcc complaining on at

Re: [libvirt] [PATCH] build: avoid non-portable cast of pthread_t

2013-05-03 Thread Daniel P. Berrange
On Thu, May 02, 2013 at 03:58:23PM -0600, Eric Blake wrote: > POSIX says pthread_t is opaque. We can't guarantee if it is scaler > or a pointer, nor what size it is; and BSD differs from Linux. > We've also had reports of gcc complaining on attempts to cast it, > if we use a cast to the wrong type

Re: [libvirt] [PATCH] build: avoid non-portable cast of pthread_t

2013-05-02 Thread Guido Günther
Hi Eric, On Thu, May 02, 2013 at 03:58:23PM -0600, Eric Blake wrote: > POSIX says pthread_t is opaque. We can't guarantee if it is scaler > or a pointer, nor what size it is; and BSD differs from Linux. > We've also had reports of gcc complaining on attempts to cast it, > if we use a cast to the w

[libvirt] [PATCH] build: avoid non-portable cast of pthread_t

2013-05-02 Thread Eric Blake
POSIX says pthread_t is opaque. We can't guarantee if it is scaler or a pointer, nor what size it is; and BSD differs from Linux. We've also had reports of gcc complaining on attempts to cast it, if we use a cast to the wrong type (for example, pointers have to be cast to void* or intptr_t before