Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 02:08:23PM +0200, Michal Privoznik wrote: > On 25.06.2012 14:03, Michal Privoznik wrote: > > On 25.06.2012 13:53, Daniel P. Berrange wrote: > >> On Fri, Jun 22, 2012 at 03:52:45PM +0200, Michal Privoznik wrote: > >>> Currently, if domain's graphic has no listenAddr set we pr

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Michal Privoznik
On 25.06.2012 14:03, Michal Privoznik wrote: > On 25.06.2012 13:53, Daniel P. Berrange wrote: >> On Fri, Jun 22, 2012 at 03:52:45PM +0200, Michal Privoznik wrote: >>> Currently, if domain's graphic has no listenAddr set we provide >>> the one from qemu.conf. However, we must make this transient to

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 02:03:04PM +0200, Michal Privoznik wrote: > On 25.06.2012 13:53, Daniel P. Berrange wrote: > > From 25273cfefec989d78ec867b6ff56e22f7317f82a Mon Sep 17 00:00:00 2001 > > From: "Daniel P. Berrange" > > Date: Mon, 25 Jun 2012 12:50:52 +0100 > > Subject: [PATCH] Include the de

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Michal Privoznik
On 25.06.2012 13:53, Daniel P. Berrange wrote: > On Fri, Jun 22, 2012 at 03:52:45PM +0200, Michal Privoznik wrote: >> Currently, if domain's graphic has no listenAddr set we provide >> the one from qemu.conf. However, we must make this transient to >> not overwrite future changes to the config file

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 03:52:45PM +0200, Michal Privoznik wrote: > Currently, if domain's graphic has no listenAddr set we provide > the one from qemu.conf. However, we must make this transient to > not overwrite future changes to the config file. Moreover, we > have to store this into domain stat

[libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-22 Thread Michal Privoznik
Currently, if domain's graphic has no listenAddr set we provide the one from qemu.conf. However, we must make this transient to not overwrite future changes to the config file. Moreover, we have to store this into domain state XML so we remain consistent on eventual config file edits. --- Since use