Re: [libvirt] [PATCH] conf: Resolve Coverity FORWARD_NULL

2015-08-05 Thread Michal Privoznik
On 04.08.2015 17:54, John Ferlan wrote: > > > On 08/04/2015 11:42 AM, Michal Privoznik wrote: >> On 04.08.2015 13:11, John Ferlan wrote: >>> The recent changes to perform SCSI device address checks during the >>> post parse callbacks ran afoul of the Coverity checker since the changes >>> assumed

Re: [libvirt] [PATCH] conf: Resolve Coverity FORWARD_NULL

2015-08-04 Thread John Ferlan
On 08/04/2015 11:42 AM, Michal Privoznik wrote: > On 04.08.2015 13:11, John Ferlan wrote: >> The recent changes to perform SCSI device address checks during the >> post parse callbacks ran afoul of the Coverity checker since the changes >> assumed that the 'xmlopt' parameter to virDomainDeviceDef

Re: [libvirt] [PATCH] conf: Resolve Coverity FORWARD_NULL

2015-08-04 Thread Michal Privoznik
On 04.08.2015 13:11, John Ferlan wrote: > The recent changes to perform SCSI device address checks during the > post parse callbacks ran afoul of the Coverity checker since the changes > assumed that the 'xmlopt' parameter to virDomainDeviceDefPostParse > would be non NULL (commit id 'ca2cf74e87');

[libvirt] [PATCH] conf: Resolve Coverity FORWARD_NULL

2015-08-04 Thread John Ferlan
The recent changes to perform SCSI device address checks during the post parse callbacks ran afoul of the Coverity checker since the changes assumed that the 'xmlopt' parameter to virDomainDeviceDefPostParse would be non NULL (commit id 'ca2cf74e87'); however, what was missed is there was an "if (x