Re: [libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash

2018-07-05 Thread Luyao Huang
Thanks for your quick review ! :) Have a nice day ! Luyao - Original Message - From: "Michal Prívozník" To: "Luyao Huang" , libvir-list@redhat.com Sent: Thursday, July 5, 2018 5:11:41 PM Subject: Re: [libvirt] [PATCH] conf: initialize character pointer xml value to

Re: [libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash

2018-07-05 Thread Michal Prívozník
On 07/05/2018 06:34 AM, Luyao Huang wrote: > If the code jump to the cleanup before assagin value to xml pointer, > libvirtd may get crashed when try to free an uninitialized pointer. > > backtrace: > > 0 0x7428d59c in free () from /lib64/libc.so.6 > 1 0x7721314a in virFree (ptr

Re: [libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash

2018-07-04 Thread Luyao Huang
@redhat.com, lhu...@redhat.com Sent: Thursday, July 5, 2018 12:43:16 PM Subject: Re: [libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Ty

[libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash

2018-07-04 Thread Luyao Huang
If the code jump to the cleanup before assagin value to xml pointer, libvirtd may get crashed when try to free an uninitialized pointer. backtrace: 0 0x7428d59c in free () from /lib64/libc.so.6 1 0x7721314a in virFree (ptrptr=ptrptr@entry=0x7fffc67f1b00) at util/viralloc.c:582