Re: [libvirt] [PATCH] config: Add listen setter

On Thu, Jul 14, 2016 at 06:57:35PM +0100, Zeeshan Ali (Khattak) wrote: > Oh and when you provide updated patches, please make the subject > prefix on emails 'gconfig' or 'libvirt-gconfig' so context is very > clear. You'll want version too so --subject-prefix="gconfig v2" would > be good. I usuall

Re: [libvirt] [PATCH] config: Add listen setter

On Thu, Jul 14, 2016 at 3:16 PM, Visarion-Mingopol Alexandru-Viorel wrote: > Actually, it seems there is some stuff to work on regarding this change. Indeed. Please keep in mind that * if we only use string types if there is no better alternatives. Static types are preferred as those make it har

Re: [libvirt] [PATCH] config: Add listen setter

Actually, it seems there is some stuff to work on regarding this change. On Wed, Jul 13, 2016 at 6:11 PM, Visarion Alexandru < viorel.visar...@gmail.com> wrote: > Learn to set the listen attribute on spice. > --- > libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++ > libvir

[libvirt] [PATCH] config: Add listen setter

Learn to set the listen attribute on spice. --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 4 3 files changed, 17 insertions(+) diff --gi