2010/8/30 Eric Blake :
> On 08/27/2010 04:10 PM, Matthias Bolte wrote:
>>
>> In v2 (attached) I made this unescape all |XX and removed the memmoves.
>>
>> To convert XX to the actual char I moved hextobin (used internally by
>> virUUIDParse) to util.c and used it here. The move is done in a
>> sepa
On 08/27/2010 04:10 PM, Matthias Bolte wrote:
In v2 (attached) I made this unescape all |XX and removed the memmoves.
To convert XX to the actual char I moved hextobin (used internally by
virUUIDParse) to util.c and used it here. The move is done in a
separate patch (attached).
ACK to both pat
2010/8/27 Eric Blake :
> On 08/27/2010 10:31 AM, Matthias Bolte wrote:
>>
>> + char *annotation = NULL;
>> + char *tmp;
>> + int length;
>
> s/int/size_t/
>
>> int controller;
>> int bus;
>> int port;
>> @@ -947,6 +950,33 @@ esxVMX_ParseConfig(esxVMX_Context *ctx, virCapsPtr
On 08/27/2010 10:31 AM, Matthias Bolte wrote:
+char *annotation = NULL;
+char *tmp;
+int length;
s/int/size_t/
int controller;
int bus;
int port;
@@ -947,6 +950,33 @@ esxVMX_ParseConfig(esxVMX_Context *ctx, virCapsPtr caps,
const char *vmx,
goto cleanu
Take care of escaping '"' and '|' (the escape character).
Add tests for this.
---
src/esx/esx_vmx.c| 124 -
tests/vmx2xmldata/vmx2xml-annotation.vmx |3 +
tests/vmx2xmldata/vmx2xml-annotation.xml | 16
tests/vmx2xmltest.c
