Re: [libvirt] [PATCH] esx: Move VMX handling code out of the driver directory

2010-12-21 Thread Matthias Bolte
2010/12/21 Eric Blake : > On 12/21/2010 09:03 AM, Matthias Bolte wrote: >> Now the VMware driver doesn't depend on the ESX driver anymore. >> >> Add a WITH_VMX option that depends on WITH_ESX and WITH_VMWARE. >> Also add a libvirt_vmx.syms file. >> >> Move some escaping functions from esx_util.c to

Re: [libvirt] [PATCH] esx: Move VMX handling code out of the driver directory

2010-12-21 Thread Justin Clift
On 22/12/2010, at 4:57 AM, Eric Blake wrote: > On 12/21/2010 10:50 AM, Justin Clift wrote: >> On 22/12/2010, at 4:40 AM, Eric Blake wrote: >> >>> 'git diff' is so awesome with renames :) >> >> Hmmm recently had a problem with it where it *insisted* that one of the >> 100+ files >> in a git r

Re: [libvirt] [PATCH] esx: Move VMX handling code out of the driver directory

2010-12-21 Thread Eric Blake
On 12/21/2010 10:50 AM, Justin Clift wrote: > On 22/12/2010, at 4:40 AM, Eric Blake wrote: > >> 'git diff' is so awesome with renames :) > > Hmmm recently had a problem with it where it *insisted* that one of the > 100+ files > in a git repo I'd been messing with was a rename of a different

Re: [libvirt] [PATCH] esx: Move VMX handling code out of the driver directory

2010-12-21 Thread Justin Clift
On 22/12/2010, at 4:40 AM, Eric Blake wrote: > 'git diff' is so awesome with renames :) Hmmm recently had a problem with it where it *insisted* that one of the 100+ files in a git repo I'd been messing with was a rename of a different file... even when it wasn't. (significantly different fi

Re: [libvirt] [PATCH] esx: Move VMX handling code out of the driver directory

2010-12-21 Thread Eric Blake
On 12/21/2010 09:03 AM, Matthias Bolte wrote: > Now the VMware driver doesn't depend on the ESX driver anymore. > > Add a WITH_VMX option that depends on WITH_ESX and WITH_VMWARE. > Also add a libvirt_vmx.syms file. > > Move some escaping functions from esx_util.c to vmx.c. > > Adapt the test su