Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread Daniel P. Berrange
On Mon, Nov 24, 2008 at 11:44:15AM -0500, David Lively wrote: > On Mon, 2008-11-24 at 17:30 +0100, Jim Meyering wrote: > > David Lively <[EMAIL PROTECTED]> wrote: > > > On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: > > >> David Lively <[EMAIL PROTECTED]> wrote: > > >> > On Fri, 2008-11-21

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread David Lively
On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: > David Lively <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > > I'm printing the (user-supplied) object names to help in debugging > > misbehaving python EventImpls (since there's no static type checking

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread David Lively
On Mon, 2008-11-24 at 17:30 +0100, Jim Meyering wrote: > David Lively <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: > >> David Lively <[EMAIL PROTECTED]> wrote: > >> > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > >> > I'm printing the (user-suppli

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread Daniel P. Berrange
On Fri, Nov 21, 2008 at 02:14:57PM -0500, David Lively wrote: > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > > No big deal, but there are several debug printf uses here that look > > like they try to print NULL pointers upon memory allocation failure. > > It's ok with glibc's printf of

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread Jim Meyering
David Lively <[EMAIL PROTECTED]> wrote: > On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: >> David Lively <[EMAIL PROTECTED]> wrote: >> > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: >> > I'm printing the (user-supplied) object names to help in debugging >> > misbehaving python Eve

Re: [libvirt] [PATCH] fix python events

2008-11-21 Thread Jim Meyering
David Lively <[EMAIL PROTECTED]> wrote: > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: >> No big deal, but there are several debug printf uses here that look >> like they try to print NULL pointers upon memory allocation failure. >> It's ok with glibc's printf of course, but not for other

Re: [libvirt] [PATCH] fix python events

2008-11-21 Thread David Lively
On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > No big deal, but there are several debug printf uses here that look > like they try to print NULL pointers upon memory allocation failure. > It's ok with glibc's printf of course, but not for others. You're right. Attached patch fixes those

Re: [libvirt] [PATCH] fix python events

2008-11-21 Thread Jim Meyering
David Lively <[EMAIL PROTECTED]> wrote: ... Hi David, No big deal, but there are several debug printf uses here that look like they try to print NULL pointers upon memory allocation failure. It's ok with glibc's printf of course, but not for others. > commit efd5098e9a834562cddbf1618e36eb43c272f

Re: [libvirt] [PATCH] fix python events

2008-11-21 Thread David Lively
Doh! ... attached :-) On Fri, 2008-11-21 at 10:30 +0100, Jim Meyering wrote: > David Lively <[EMAIL PROTECTED]> wrote: > > This patch gets python events working again after upstream changes, and > > make the test implementation properly clean up after itself and > > implement the new EventImpl AP

Re: [libvirt] [PATCH] fix python events

2008-11-21 Thread Jim Meyering
David Lively <[EMAIL PROTECTED]> wrote: > This patch gets python events working again after upstream changes, and > make the test implementation properly clean up after itself and > implement the new EventImpl API properly. > > Note that the Python RemoveHandle and RemoveTimeout implementations > s

[libvirt] [PATCH] fix python events

2008-11-20 Thread David Lively
This patch gets python events working again after upstream changes, and make the test implementation properly clean up after itself and implement the new EventImpl API properly. Note that the Python RemoveHandle and RemoveTimeout implementations should return the opaque object registered by the co