Re: [libvirt] [PATCH] lib: Avoid double free when passing FDs with virCommandPassFD()

2019-05-17 Thread Ján Tomko
On Tue, Apr 30, 2019 at 11:47:51AM +0200, Michal Privoznik wrote: If an FD is passed into a child using: virCommandPassFD(cmd, fd, VIR_COMMAND_PASS_FD_CLOSE_PARENT); then the parent should refrain from touching @fd thereafter. This is even documented in virCommandPassFD() comment. The reason i

[libvirt] [PATCH] lib: Avoid double free when passing FDs with virCommandPassFD()

2019-04-30 Thread Michal Privoznik
If an FD is passed into a child using: virCommandPassFD(cmd, fd, VIR_COMMAND_PASS_FD_CLOSE_PARENT); then the parent should refrain from touching @fd thereafter. This is even documented in virCommandPassFD() comment. The reason is that either at virCommandRun()/virCommandRunAsync() or virCommand