Re: [libvirt] [PATCH] libvirt: Change maximum CPU per node calculation.

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 02:50:28PM +0200, Viktor Mihajlovski wrote: > On 10/10/2012 02:23 PM, Daniel P. Berrange wrote: > > > >NACK, this breaks ABI compatibility of the public API > > > > I see ... before I venture a different approach: would the > definition of VIR_NODEINFO_MAXCPUS be considered

Re: [libvirt] [PATCH] libvirt: Change maximum CPU per node calculation.

2012-10-10 Thread Viktor Mihajlovski
On 10/10/2012 02:23 PM, Daniel P. Berrange wrote: NACK, this breaks ABI compatibility of the public API I see ... before I venture a different approach: would the definition of VIR_NODEINFO_MAXCPUS be considered part of the public API as well? -- Mit freundlichen Grüßen/Kind Regards Vik

Re: [libvirt] [PATCH] libvirt: Change maximum CPU per node calculation.

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 02:05:25PM +0200, Viktor Mihajlovski wrote: > The macro VIR_NODEINFO_MAXCPUS computes the maximum number of supported > CPUs for a node as the product of sockets, cores and threads from the > virNodeInfo structure. > Since topology cannot be discovered for offline CPUs, any

[libvirt] [PATCH] libvirt: Change maximum CPU per node calculation.

2012-10-10 Thread Viktor Mihajlovski
The macro VIR_NODEINFO_MAXCPUS computes the maximum number of supported CPUs for a node as the product of sockets, cores and threads from the virNodeInfo structure. Since topology cannot be discovered for offline CPUs, any of the values for sockets, cores or threads can be wrong (too small). As a c