Re: [libvirt] [PATCH] libxl: Resove Coverity dead_error_begin

2014-01-31 Thread Eric Blake
On 01/31/2014 10:11 AM, John Ferlan wrote: >>> >>> +/* coverity[dead_error_begin] */ >>> default: >>> break; >>> } >>> >> >> Why not just delete the label instead; then you don't need a Coverity >> marker? >> > > So are you advocating for removal of the ot

Re: [libvirt] [PATCH] libxl: Resove Coverity dead_error_begin

2014-01-31 Thread John Ferlan
On 01/31/2014 11:45 AM, Eric Blake wrote: > On 01/31/2014 09:35 AM, John Ferlan wrote: >> Coverity complains about default: label not be able to be reached. It's by >> design for the code, so just add a Coverity tag for dead_error_begin >> >> Signed-off-by: John Ferlan >> --- >> src/libxl/libx

Re: [libvirt] [PATCH] libxl: Resove Coverity dead_error_begin

2014-01-31 Thread Eric Blake
On 01/31/2014 09:35 AM, John Ferlan wrote: > Coverity complains about default: label not be able to be reached. It's by > design for the code, so just add a Coverity tag for dead_error_begin > > Signed-off-by: John Ferlan > --- > src/libxl/libxl_driver.c | 1 + > 1 file changed, 1 insertion(+)

[libvirt] [PATCH] libxl: Resove Coverity dead_error_begin

2014-01-31 Thread John Ferlan
Coverity complains about default: label not be able to be reached. It's by design for the code, so just add a Coverity tag for dead_error_begin Signed-off-by: John Ferlan --- src/libxl/libxl_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_