Re: [libvirt] [PATCH] libxl: fix default vram setting for implicit video device

2016-05-12 Thread Joao Martins
On 05/11/2016 11:21 PM, Jim Fehlig wrote: > On 05/11/2016 05:22 AM, Joao Martins wrote: >> On 05/11/2016 06:01 AM, Jim Fehlig wrote: >>> Commit 6879be48 moved adding of an implicit video device after XML >>> parsing. As a result, libxlDomainDeviceDefPostParse() is no longer >>> called to set the

Re: [libvirt] [PATCH] libxl: fix default vram setting for implicit video device

2016-05-11 Thread Jim Fehlig
On 05/11/2016 05:22 AM, Joao Martins wrote: > On 05/11/2016 06:01 AM, Jim Fehlig wrote: >> Commit 6879be48 moved adding of an implicit video device after XML >> parsing. As a result, libxlDomainDeviceDefPostParse() is no longer >> called to set the default vram when adding an implicit device. >> Co

Re: [libvirt] [PATCH] libxl: fix default vram setting for implicit video device

2016-05-11 Thread Joao Martins
On 05/11/2016 06:01 AM, Jim Fehlig wrote: > Commit 6879be48 moved adding of an implicit video device after XML > parsing. As a result, libxlDomainDeviceDefPostParse() is no longer > called to set the default vram when adding an implicit device. > Commit 6879be48 assumes virDomainVideoDefaultRAM() w

Re: [libvirt] [PATCH] libxl: fix default vram setting for implicit video device

2016-05-11 Thread Ján Tomko
On Tue, May 10, 2016 at 11:01:17PM -0600, Jim Fehlig wrote: > Commit 6879be48 moved adding of an implicit video device after XML > parsing. As a result, libxlDomainDeviceDefPostParse() is no longer > called to set the default vram when adding an implicit device. > Commit 6879be48 assumes virDomainV

[libvirt] [PATCH] libxl: fix default vram setting for implicit video device

2016-05-10 Thread Jim Fehlig
Commit 6879be48 moved adding of an implicit video device after XML parsing. As a result, libxlDomainDeviceDefPostParse() is no longer called to set the default vram when adding an implicit device. Commit 6879be48 assumes virDomainVideoDefaultRAM() will set the default vram, but it returns 0 if the