On 10/14/11 2:08 PM, "Eric Blake" wrote:
> On 10/14/2011 03:05 PM, Roopa Prabhu wrote:
>>> I had already pushed mine. Yours is missing a virReportOOMError() on
>>> allocation failure; but ACK with that improvement.
>>>
>> Great. Thanks!. I will send out a patch for the bug fix and later work
On 10/14/2011 03:05 PM, Roopa Prabhu wrote:
I had already pushed mine. Yours is missing a virReportOOMError() on
allocation failure; but ACK with that improvement.
Great. Thanks!. I will send out a patch for the bug fix and later work on
the fixing the error return convention.
I already push
On 10/14/11 1:55 PM, "Eric Blake" wrote:
> On 10/14/2011 02:41 PM, Roopa Prabhu wrote:
>>
>>
>>
>> On 10/13/11 3:49 PM, "Eric Blake" wrote:
>>
>>> Detected by Coverity. Leak present since commit ca3b22b.
>>>
>>> * src/util/macvtap.c (doPortProfileOp8021Qbh): Release device name.
>>> ---
On 10/14/2011 02:41 PM, Roopa Prabhu wrote:
On 10/13/11 3:49 PM, "Eric Blake" wrote:
Detected by Coverity. Leak present since commit ca3b22b.
* src/util/macvtap.c (doPortProfileOp8021Qbh): Release device name.
---
getPhysfnDev allocates physfndev, but nothing freed it.
Pushing under the t
On 10/13/11 3:49 PM, "Eric Blake" wrote:
> Detected by Coverity. Leak present since commit ca3b22b.
>
> * src/util/macvtap.c (doPortProfileOp8021Qbh): Release device name.
> ---
> getPhysfnDev allocates physfndev, but nothing freed it.
> Pushing under the trivial rule.
>
> src/util/macvtap
Detected by Coverity. Leak present since commit ca3b22b.
* src/util/macvtap.c (doPortProfileOp8021Qbh): Release device name.
---
getPhysfnDev allocates physfndev, but nothing freed it.
Pushing under the trivial rule.
src/util/macvtap.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-