Re: [libvirt] [PATCH] net: merge virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC

2014-06-29 Thread Daniel Veillard
On Fri, Jun 27, 2014 at 09:45:09AM +0200, Peter Krempa wrote: > On 06/26/14 17:29, Ján Tomko wrote: > > On 06/26/2014 04:51 PM, Peter Krempa wrote: > >> Instead of maintaining two very similar APIs, add the "@mac" parameter > >> to virNetworkGetDHCPLeases and kill virNetworkGetDHCPLeasesForMAC. Bot

Re: [libvirt] [PATCH] net: merge virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC

2014-06-27 Thread Peter Krempa
On 06/26/14 17:29, Ján Tomko wrote: > On 06/26/2014 04:51 PM, Peter Krempa wrote: >> Instead of maintaining two very similar APIs, add the "@mac" parameter >> to virNetworkGetDHCPLeases and kill virNetworkGetDHCPLeasesForMAC. Both >> of those functions would return data the same way, so making @mac

Re: [libvirt] [PATCH] net: merge virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC

2014-06-26 Thread Ján Tomko
On 06/26/2014 04:51 PM, Peter Krempa wrote: > Instead of maintaining two very similar APIs, add the "@mac" parameter > to virNetworkGetDHCPLeases and kill virNetworkGetDHCPLeasesForMAC. Both > of those functions would return data the same way, so making @mac an > optional filter simplifies a lot of

[libvirt] [PATCH] net: merge virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC

2014-06-26 Thread Peter Krempa
Instead of maintaining two very similar APIs, add the "@mac" parameter to virNetworkGetDHCPLeases and kill virNetworkGetDHCPLeasesForMAC. Both of those functions would return data the same way, so making @mac an optional filter simplifies a lot of stuff. --- daemon/remote.c | 69 +