Re: [libvirt] [PATCH] network: Set to NULL after virNetworkDefFree()

2012-10-18 Thread Laine Stump
On 10/18/2012 10:44 AM, Michal Privoznik wrote: > which frees all allocated memory but doesn't set the passed pointer to > NULL. Therefore, we must do it ourselves. This is causing actual > libvirtd crash: Basically, when doing 'virsh net-edit' the newDef should > be dropped. Well, when you're d

Re: [libvirt] [PATCH] network: Set to NULL after virNetworkDefFree()

2012-10-18 Thread Michal Privoznik
On 18.10.2012 17:02, Jiri Denemark wrote: > On Thu, Oct 18, 2012 at 16:44:24 +0200, Michal Privoznik wrote: >> which frees all allocated memory but doesn't set the passed pointer to >> NULL. Therefore, we must do it ourselves. This is causing actual >> libvirtd crash: Basically, when doing 'virsh

Re: [libvirt] [PATCH] network: Set to NULL after virNetworkDefFree()

2012-10-18 Thread Jiri Denemark
On Thu, Oct 18, 2012 at 16:44:24 +0200, Michal Privoznik wrote: > which frees all allocated memory but doesn't set the passed pointer to > NULL. Therefore, we must do it ourselves. This is causing actual > libvirtd crash: Basically, when doing 'virsh net-edit' the newDef should > be dropped. And

[libvirt] [PATCH] network: Set to NULL after virNetworkDefFree()

2012-10-18 Thread Michal Privoznik
which frees all allocated memory but doesn't set the passed pointer to NULL. Therefore, we must do it ourselves. This is causing actual libvirtd crash: Basically, when doing 'virsh net-edit' the newDef should be dropped. And the memory is freed, indeed. However, the pointer is not set to NULL but