Re: [libvirt] [PATCH] network_conf.c: correct the value of the 'result' variable

2013-11-01 Thread Hongwei Bi
2013/11/1 Eric Blake : > On 11/01/2013 03:54 AM, Hongwei Bi wrote: >> 2013/11/1 Eric Blake : >>> [off-list] >>> >>> On 10/31/2013 06:20 PM, Hongwei Bi wrote: >>> >>> Your system clock is off. From your headers: > > I'm a bit surprised that you re-added the list regarding an off-list > suggestion;

Re: [libvirt] [PATCH] network_conf.c: correct the value of the 'result' variable

2013-11-01 Thread Eric Blake
On 11/01/2013 03:54 AM, Hongwei Bi wrote: > 2013/11/1 Eric Blake : >> [off-list] >> >> On 10/31/2013 06:20 PM, Hongwei Bi wrote: >> >> Your system clock is off. From your headers: I'm a bit surprised that you re-added the list regarding an off-list suggestion; but thank you for fixing your system

Re: [libvirt] [PATCH] network_conf.c: correct the value of the 'result' variable

2013-11-01 Thread Hongwei Bi
2013/11/1 Eric Blake : > [off-list] > > On 10/31/2013 06:20 PM, Hongwei Bi wrote: > > Your system clock is off. From your headers: > > Received: from localhost ([112.23.86.63]) > by mx.google.com with ESMTPSA id q4sm5224371pba.12.2013.10.31.09.39.20 > for > (version=TLSv1.

Re: [libvirt] [PATCH] network_conf.c: correct the value of the 'result' variable

2013-11-01 Thread Laine Stump
On 10/31/2013 07:18 PM, Eric Blake wrote: > On 10/31/2013 06:20 PM, Hongwei Bi wrote: >> The result variable in virNetworkDNSDefFormat() function should be >> initialized to -1 at first,only in this way can we use it properly. >> >> Signed-off-by: Hongwei Bi >> --- >> src/conf/network_conf.c | 4

Re: [libvirt] [PATCH] network_conf.c: correct the value of the 'result' variable

2013-10-31 Thread Eric Blake
On 10/31/2013 06:20 PM, Hongwei Bi wrote: > The result variable in virNetworkDNSDefFormat() function should be > initialized to -1 at first,only in this way can we use it properly. > > Signed-off-by: Hongwei Bi > --- > src/conf/network_conf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deleti

[libvirt] [PATCH] network_conf.c: correct the value of the 'result' variable

2013-10-31 Thread Hongwei Bi
The result variable in virNetworkDNSDefFormat() function should be initialized to -1 at first,only in this way can we use it properly. Signed-off-by: Hongwei Bi --- src/conf/network_conf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/network_conf.c b/src/conf/n