Re: [libvirt] [PATCH] qemu: Add quotes to kernel command line of direct kernel boot

2012-08-28 Thread Zhou Zheng Sheng
Thanks Eric! After reading the code of virCommandRun and virExecWithHook, I know there is no problem of passing arguments. On 08/28/2012 12:06, Eric Blake wrote: On 08/27/2012 08:05 PM, Zhou Zheng Sheng wrote: When passing kernel command line arguments, it is possible to have spaces. The argum

Re: [libvirt] [PATCH] qemu: Add quotes to kernel command line of direct kernel boot

2012-08-27 Thread Eric Blake
On 08/27/2012 08:05 PM, Zhou Zheng Sheng wrote: > When passing kernel command line arguments, it is possible to have > spaces. The arguments should be protected in qoutes. NACK. > If the contents in are passed as-is to qemu, then qemu will see > qemu ... -append console=ttyS0 ks=http://exampl

[libvirt] [PATCH] qemu: Add quotes to kernel command line of direct kernel boot

2012-08-27 Thread Zhou Zheng Sheng
When passing kernel command line arguments, it is possible to have spaces. The arguments should be protected in qoutes. In http://libvirt.org/formatdomain.html "direct kernel boot" section, there is an example. ... hvm /usr/lib/xen/boot/hvmloader /root/f8-i386-vmlinuz /root/f