Re: [libvirt] [PATCH] qemu: Avoid overflow when setting migration speed on inactive domains

2014-04-25 Thread Jiri Denemark
On Fri, Apr 25, 2014 at 08:09:10 -0600, Eric Blake wrote: > On 04/25/2014 08:04 AM, Jiri Denemark wrote: > > Commit c4206d7 fixed the overflow for running domains. However, we need > > a similar check when setting migration speed on inactive domains. > > > > At first look, it may seem the check in

Re: [libvirt] [PATCH] qemu: Avoid overflow when setting migration speed on inactive domains

2014-04-25 Thread Eric Blake
On 04/25/2014 08:04 AM, Jiri Denemark wrote: > Commit c4206d7 fixed the overflow for running domains. However, we need > a similar check when setting migration speed on inactive domains. > > At first look, it may seem the check in c4206d7 is now redundant but > qemuDomainMigrateSetMaxSpeed is not

[libvirt] [PATCH] qemu: Avoid overflow when setting migration speed on inactive domains

2014-04-25 Thread Jiri Denemark
Commit c4206d7 fixed the overflow for running domains. However, we need a similar check when setting migration speed on inactive domains. At first look, it may seem the check in c4206d7 is now redundant but qemuDomainMigrateSetMaxSpeed is not the only caller of qemuMonitorSetMigrationSpeed so we n