Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-16 Thread Adam Litke
On 08/15/2011 10:28 PM, Osier Yang wrote: > 于 2011年08月16日 00:40, Adam Litke 写道: >> Hi Osier, >> >> Just to be clear, this is a cleanup not a bugfix right? The current >> code should be working properly as written. > > No, "virDomainMemoryStats" will return empty result if libvirt > communicates t

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Osier Yang
于 2011年08月16日 00:40, Adam Litke 写道: Hi Osier, Just to be clear, this is a cleanup not a bugfix right? The current code should be working properly as written. No, "virDomainMemoryStats" will return empty result if libvirt communicates to qemu monitor in text mode. Actually this is reported by

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Osier Yang
于 2011年08月16日 00:27, Adam Litke 写道: > On 08/15/2011 08:23 AM, Osier Yang wrote: >> 于 2011年08月15日 21:58, Osier Yang 写道: >>> * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as >>> "balloon: actual=", which cause "actual=" is stripped early before >>> the real parsing. This patch changes BA

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Adam Litke
On 08/15/2011 11:50 AM, Daniel P. Berrange wrote: > On Mon, Aug 15, 2011 at 11:27:43AM -0500, Adam Litke wrote: >> On 08/15/2011 08:23 AM, Osier Yang wrote: >>> 于 2011年08月15日 21:58, Osier Yang 写道: * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as "balloon: actual=", which ca

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Daniel P. Berrange
On Mon, Aug 15, 2011 at 11:27:43AM -0500, Adam Litke wrote: > On 08/15/2011 08:23 AM, Osier Yang wrote: > > 于 2011年08月15日 21:58, Osier Yang 写道: > >> * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as > >> "balloon: actual=", which cause "actual=" is stripped early before > >> the real pa

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Adam Litke
Hi Osier, Just to be clear, this is a cleanup not a bugfix right? The current code should be working properly as written. On 08/15/2011 08:58 AM, Osier Yang wrote: > * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as > "balloon: actual=", which cause "actual=" is stripped early before

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Adam Litke
On 08/15/2011 08:23 AM, Osier Yang wrote: > 于 2011年08月15日 21:58, Osier Yang 写道: >> * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as >> "balloon: actual=", which cause "actual=" is stripped early before >> the real parsing. This patch changes BALLOON_PREFIX into "balloon: ", >> and modi

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Osier Yang
于 2011年08月15日 21:58, Osier Yang 写道: > * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as > "balloon: actual=", which cause "actual=" is stripped early before > the real parsing. This patch changes BALLOON_PREFIX into "balloon: ", > and modifies related functions, also renames > "qemuMoni

[libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Osier Yang
* src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as "balloon: actual=", which cause "actual=" is stripped early before the real parsing. This patch changes BALLOON_PREFIX into "balloon: ", and modifies related functions, also renames "qemuMonitorParseExtraBalloonInfo" to "qemuMonitorParse