Re: [libvirt] [PATCH] qemu: Set migration FD blocking

2013-03-26 Thread Cole Robinson
On 03/26/2013 05:04 PM, Eric Blake wrote: > On 03/26/2013 02:52 PM, Cole Robinson wrote: > > src/qemu/qemu_migration.c | 7 +++ > 1 file changed, 7 insertions(+) Thanks for figuring it all out! I definitely hit this one, while trying to help someone on IRC. A

Re: [libvirt] [PATCH] qemu: Set migration FD blocking

2013-03-26 Thread Eric Blake
On 03/26/2013 02:52 PM, Cole Robinson wrote: src/qemu/qemu_migration.c | 7 +++ 1 file changed, 7 insertions(+) >>> >>> Thanks for figuring it all out! I definitely hit this one, while trying >>> to help someone on IRC. >>> >>> ACK, and definitely 1.0.4 material. >>> >> >> Thanks,

Re: [libvirt] [PATCH] qemu: Set migration FD blocking

2013-03-26 Thread Cole Robinson
On 03/26/2013 12:20 PM, Michal Privoznik wrote: > On 26.03.2013 17:08, Eric Blake wrote: >> On 03/26/2013 08:55 AM, Michal Privoznik wrote: >>> Since we switched from direct host migration scheme to the one, >>> where we connect to the destination and then just pass a FD to a >>> qemu, we have unco

Re: [libvirt] [PATCH] qemu: Set migration FD blocking

2013-03-26 Thread Doug Goldstein
On Tue, Mar 26, 2013 at 11:20 AM, Michal Privoznik wrote: > On 26.03.2013 17:08, Eric Blake wrote: >> On 03/26/2013 08:55 AM, Michal Privoznik wrote: >>> Since we switched from direct host migration scheme to the one, >>> where we connect to the destination and then just pass a FD to a >>> qemu, w

Re: [libvirt] [PATCH] qemu: Set migration FD blocking

2013-03-26 Thread Eric Blake
On 03/26/2013 08:55 AM, Michal Privoznik wrote: > Since we switched from direct host migration scheme to the one, > where we connect to the destination and then just pass a FD to a > qemu, we have uncovered a qemu bug. Qemu expects migration FD to > block. However, we are passing a nonblocking one

Re: [libvirt] [PATCH] qemu: Set migration FD blocking

2013-03-26 Thread Michal Privoznik
On 26.03.2013 17:08, Eric Blake wrote: > On 03/26/2013 08:55 AM, Michal Privoznik wrote: >> Since we switched from direct host migration scheme to the one, >> where we connect to the destination and then just pass a FD to a >> qemu, we have uncovered a qemu bug. Qemu expects migration FD to >> bloc

[libvirt] [PATCH] qemu: Set migration FD blocking

2013-03-26 Thread Michal Privoznik
Since we switched from direct host migration scheme to the one, where we connect to the destination and then just pass a FD to a qemu, we have uncovered a qemu bug. Qemu expects migration FD to block. However, we are passing a nonblocking one which results in cryptic error messages like: qemu: w