On 05/07/2013 09:12 AM, Laine Stump wrote:
>
>> However, if we are gonna move all the allocation code out of
>> the qemuBuildCommandLine we should remember now, that there are gonna be
>> several FDs being passed (multiple for /dev/net/tun and for /dev/vhost-net).
>
> Yep. That's the thing (alon
On 05/07/2013 10:57 AM, Michal Privoznik wrote:
> On 07.05.2013 16:47, Laine Stump wrote:
>> On 05/07/2013 05:52 AM, Michal Privoznik wrote:
>>> On 06.05.2013 22:16, Laine Stump wrote:
>>> I'd expect a one line comment here at least to give a reason why we are
>>> skipping VIR_DOMAIN_NET_TYP
On 07.05.2013 16:47, Laine Stump wrote:
> On 05/07/2013 05:52 AM, Michal Privoznik wrote:
>> On 06.05.2013 22:16, Laine Stump wrote:
>>>
>> I'd expect a one line comment here at least to give a reason why we are
>> skipping VIR_DOMAIN_NET_TYPE_HOSTDEV. Something like:
>> /* hostdev interfaces alr
On 05/07/2013 05:52 AM, Michal Privoznik wrote:
> On 06.05.2013 22:16, Laine Stump wrote:
>>
> I'd expect a one line comment here at least to give a reason why we are
> skipping VIR_DOMAIN_NET_TYPE_HOSTDEV. Something like:
> /* hostdev interfaces already handled by qemuNetworkPrepareDevices */
>
On 06.05.2013 22:16, Laine Stump wrote:
> VFIO device assignment requires a cgroup ACL to be setup for access to
> the /dev/vfio/nn "group" device for any devices that will be assigned
> to a guest. In the case of a host device that is allocated from a
> pool, it was being allocated during qemuBuil
VFIO device assignment requires a cgroup ACL to be setup for access to
the /dev/vfio/nn "group" device for any devices that will be assigned
to a guest. In the case of a host device that is allocated from a
pool, it was being allocated during qemuBuildCommandLine(), which is
called by qemuProcessSt
