Re: [libvirt] [PATCH] qemu: blockjob: Fix saving of inactive XML after completed legacy blockjob

2019-05-17 Thread Ján Tomko
On Fri, May 17, 2019 at 10:22:16AM +0200, Peter Krempa wrote: Commit 0ba9afc6b28 introduced a logic bug where we will never save the On second glance, that commit still looks okay to me logic-wise. Commit c257352797 seems to be the culprit here. inactive XML after a blockjob as the variable w

Re: [libvirt] [PATCH] qemu: blockjob: Fix saving of inactive XML after completed legacy blockjob

2019-05-17 Thread Thomas Stein
Thank you Peter. On 2019-05-17 10:22, Peter Krempa wrote: Commit 0ba9afc6b28 introduced a logic bug where we will never save the inactive XML after a blockjob as the variable which was determining whether to do so is cleared right before. Thus even if we correctly modify the inactive state it

[libvirt] [PATCH] qemu: blockjob: Fix saving of inactive XML after completed legacy blockjob

2019-05-17 Thread Peter Krempa
Commit 0ba9afc6b28 introduced a logic bug where we will never save the inactive XML after a blockjob as the variable which was determining whether to do so is cleared right before. Thus even if we correctly modify the inactive state it will be rolled back when libvirtd is restarted. Reported-by: T