Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-26 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Wed, Feb 26, 2014 at 09:12:11AM -0700, Eric Blake wrote: > > On 02/26/2014 08:57 AM, Roman Bogorodskiy wrote: > > >> > > >> Conceptually ok, but I fear this impl will result in the logs getting > > >> polluted with "cannot delete tap device" or similar log messages

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-26 Thread Daniel P. Berrange
On Wed, Feb 26, 2014 at 09:12:11AM -0700, Eric Blake wrote: > On 02/26/2014 08:57 AM, Roman Bogorodskiy wrote: > >> > >> Conceptually ok, but I fear this impl will result in the logs getting > >> polluted with "cannot delete tap device" or similar log messages on OS > >> where TAP device deletion i

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-26 Thread Eric Blake
On 02/26/2014 08:57 AM, Roman Bogorodskiy wrote: >> >> Conceptually ok, but I fear this impl will result in the logs getting >> polluted with "cannot delete tap device" or similar log messages on OS >> where TAP device deletion is automatic. > > Do you have an idea about better way to do that? Ma

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-26 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Mon, Feb 24, 2014 at 11:12:33PM +0400, Roman Bogorodskiy wrote: > > We have to explicitly destroy TAP devices on FreeBSD because > > they're not freed after being closed, otherwise we end up with > > orphaned TAP devices after destroying a domain. > > --- > > src/

Re: [libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-25 Thread Daniel P. Berrange
On Mon, Feb 24, 2014 at 11:12:33PM +0400, Roman Bogorodskiy wrote: > We have to explicitly destroy TAP devices on FreeBSD because > they're not freed after being closed, otherwise we end up with > orphaned TAP devices after destroying a domain. > --- > src/qemu/qemu_process.c | 7 +++ > 1 file

[libvirt] [PATCH] qemu: cleanup tap devices on FreeBSD

2014-02-24 Thread Roman Bogorodskiy
We have to explicitly destroy TAP devices on FreeBSD because they're not freed after being closed, otherwise we end up with orphaned TAP devices after destroying a domain. --- src/qemu/qemu_process.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu