Re: [libvirt] [PATCH] qemu: domain: validate memory access during validate domain config

2018-08-29 Thread John Ferlan
On 08/27/2018 11:51 PM, lhuang wrote: > > > On 08/28/2018 06:01 AM, John Ferlan wrote: >> >> On 08/20/2018 05:48 AM, Luyao Huang wrote: >>> commit 6534b3c4 try to raise an error when there is no numa nodes but >>> set access='shared' in domain config. In that commit, we add a memory >>> access

Re: [libvirt] [PATCH] qemu: domain: validate memory access during validate domain config

2018-08-27 Thread lhuang
On 08/28/2018 06:01 AM, John Ferlan wrote: On 08/20/2018 05:48 AM, Luyao Huang wrote: commit 6534b3c4 try to raise an error when there is no numa nodes but set access='shared' in domain config. In that commit, we add a memory access validate function for memory device, but this check is not

Re: [libvirt] [PATCH] qemu: domain: validate memory access during validate domain config

2018-08-27 Thread John Ferlan
On 08/20/2018 05:48 AM, Luyao Huang wrote: > commit 6534b3c4 try to raise an error when there is no numa nodes but > set access='shared' in domain config. In that commit, we add a memory access > validate function for memory device, but this check is not related to memory > device and won't work

[libvirt] [PATCH] qemu: domain: validate memory access during validate domain config

2018-08-20 Thread Luyao Huang
commit 6534b3c4 try to raise an error when there is no numa nodes but set access='shared' in domain config. In that commit, we add a memory access validate function for memory device, but this check is not related to memory device and won't work if there is no memory device in guest xml. Move the