Re: [libvirt] [PATCH] qemuAgentDispose: Reset lastError

2013-12-04 Thread Wangyufei (James)
ngyufei (James); libvir-list@redhat.com > Cc: zhouyimin Zhou(Yimin); Wangrui (K) > Subject: Re: [libvirt] [PATCH] qemuAgentDispose: Reset lastError > > On 12/04/2013 02:44 PM, Eric Blake wrote: > > On 12/02/2013 07:59 PM, Wangyufei (James) wrote: > >> When an error occurr

Re: [libvirt] [PATCH] qemuAgentDispose: Reset lastError

2013-12-04 Thread Eric Blake
On 12/04/2013 02:44 PM, Eric Blake wrote: > On 12/02/2013 07:59 PM, Wangyufei (James) wrote: >> When an error occurred in qemuAgentIO, it will be saved in mon->lastError, >> but it will not be freed at last. >> >> Signed-off-by: Zhou Yimin I've already pushed, but note that the commit is now att

Re: [libvirt] [PATCH] qemuAgentDispose: Reset lastError

2013-12-04 Thread Eric Blake
On 12/02/2013 07:59 PM, Wangyufei (James) wrote: > When an error occurred in qemuAgentIO, it will be saved in mon->lastError, > but it will not be freed at last. > So I add the following code to fix it. > > ==22219== 54 bytes in 1 blocks are definitely lost in loss record 982 of 1,379 > ==22219==

[libvirt] [PATCH] qemuAgentDispose: Reset lastError

2013-12-02 Thread Wangyufei (James)
When an error occurred in qemuAgentIO, it will be saved in mon->lastError, but it will not be freed at last. So I add the following code to fix it. ==22219== 54 bytes in 1 blocks are definitely lost in loss record 982 of 1,379 ==22219==at 0x4C26B9B: malloc (vg_replace_malloc.c:263) ==22219==