Re: [libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change

2018-01-05 Thread Marc Hartmayer
On Fri, Jan 05, 2018 at 02:24 PM +0100, Michal Privoznik wrote: > On 01/05/2018 01:16 PM, Marc Hartmayer wrote: >> On Wed, Dec 13, 2017 at 03:30 PM +0100, Michal Privoznik >> wrote: >>> Since we have user aliases it may happen that users want to >>> change it using 'update-device'. Instead of i

Re: [libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change

2018-01-05 Thread Michal Privoznik
On 01/05/2018 01:16 PM, Marc Hartmayer wrote: > On Wed, Dec 13, 2017 at 03:30 PM +0100, Michal Privoznik > wrote: >> Since we have user aliases it may happen that users want to >> change it using 'update-device'. Instead of ignoring it silently, >> error out loudly. >> >> Signed-off-by: Michal Pr

Re: [libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change

2018-01-05 Thread Marc Hartmayer
On Wed, Dec 13, 2017 at 03:30 PM +0100, Michal Privoznik wrote: > Since we have user aliases it may happen that users want to > change it using 'update-device'. Instead of ignoring it silently, > error out loudly. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 8 >

Re: [libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change

2018-01-05 Thread John Ferlan
On 01/05/2018 03:20 AM, Michal Privoznik wrote: > On 01/05/2018 01:15 AM, John Ferlan wrote: >> >> >> On 12/13/2017 09:30 AM, Michal Privoznik wrote: >>> Since we have user aliases it may happen that users want to >>> change it using 'update-device'. Instead of ignoring it silently, >>> error out

Re: [libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change

2018-01-05 Thread Michal Privoznik
On 01/05/2018 01:15 AM, John Ferlan wrote: > > > On 12/13/2017 09:30 AM, Michal Privoznik wrote: >> Since we have user aliases it may happen that users want to >> change it using 'update-device'. Instead of ignoring it silently, >> error out loudly. >> >> Signed-off-by: Michal Privoznik >> --- >

Re: [libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change

2018-01-04 Thread John Ferlan
On 12/13/2017 09:30 AM, Michal Privoznik wrote: > Since we have user aliases it may happen that users want to > change it using 'update-device'. Instead of ignoring it silently, > error out loudly. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 8 > 1 file change

Re: [libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change

2018-01-04 Thread Michal Privoznik
On 12/13/2017 03:30 PM, Michal Privoznik wrote: > Since we have user aliases it may happen that users want to > change it using 'update-device'. Instead of ignoring it silently, > error out loudly. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 8 > 1 file changed,

[libvirt] [PATCH] qemuDomainDiskChangeSupported: Forbid alias change

2017-12-13 Thread Michal Privoznik
Since we have user aliases it may happen that users want to change it using 'update-device'. Instead of ignoring it silently, error out loudly. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 8 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu