Re: [libvirt] [PATCH] qemu_blockjob: Remove secdriver metadata for whole backing chain on job completion

2019-09-25 Thread Peter Krempa
On Mon, Sep 16, 2019 at 16:13:39 +0200, Peter Krempa wrote: > On Mon, Sep 16, 2019 at 12:34:32 +0200, Michal Privoznik wrote: > > Turns out, block mirror is not the only job a disk can have. It > > can also do commits of one layer into the other. Or possibly some > > other tricks too. Problem is th

Re: [libvirt] [PATCH] qemu_blockjob: Remove secdriver metadata for whole backing chain on job completion

2019-09-16 Thread Peter Krempa
On Mon, Sep 16, 2019 at 12:34:32 +0200, Michal Privoznik wrote: > Turns out, block mirror is not the only job a disk can have. It > can also do commits of one layer into the other. Or possibly some > other tricks too. Problem is that while we set seclabels on given > layers of backing chain when th

[libvirt] [PATCH] qemu_blockjob: Remove secdriver metadata for whole backing chain on job completion

2019-09-16 Thread Michal Privoznik
Turns out, block mirror is not the only job a disk can have. It can also do commits of one layer into the other. Or possibly some other tricks too. Problem is that while we set seclabels on given layers of backing chain when the job is starting (via qemuDomainStorageSourceAccessAllow()) we don't re