Re: [libvirt] [PATCH] qemuxml2argvtest: uncoditionally mock NUMA routines

2016-05-16 Thread Roman Bogorodskiy
Ján Tomko wrote: > On Fri, May 13, 2016 at 08:53:08PM +0300, Roman Bogorodskiy wrote: > > Ján Tomko wrote: > > > > > On Thu, May 12, 2016 at 10:47:04AM +0300, Roman Bogorodskiy wrote: > > > > Currently, qemuxml2argvmock.c only mocks virNumaNodeIsAvailable(), and > > > > only if libvirt was bu

Re: [libvirt] [PATCH] qemuxml2argvtest: uncoditionally mock NUMA routines

2016-05-16 Thread Ján Tomko
On Fri, May 13, 2016 at 08:53:08PM +0300, Roman Bogorodskiy wrote: > Ján Tomko wrote: > > > On Thu, May 12, 2016 at 10:47:04AM +0300, Roman Bogorodskiy wrote: > > > Currently, qemuxml2argvmock.c only mocks virNumaNodeIsAvailable(), and > > > only if libvirt was built with NUMA support. This caus

Re: [libvirt] [PATCH] qemuxml2argvtest: uncoditionally mock NUMA routines

2016-05-13 Thread Roman Bogorodskiy
Ján Tomko wrote: > On Thu, May 12, 2016 at 10:47:04AM +0300, Roman Bogorodskiy wrote: > > Currently, qemuxml2argvmock.c only mocks virNumaNodeIsAvailable(), and > > only if libvirt was built with NUMA support. This causes some test > > failures where NUMA is involved. > > > > This is misleadin

Re: [libvirt] [PATCH] qemuxml2argvtest: uncoditionally mock NUMA routines

2016-05-13 Thread Andrea Bolognani
On Fri, 2016-05-13 at 14:07 +0200, Ján Tomko wrote: > On Thu, May 12, 2016 at 10:47:04AM +0300, Roman Bogorodskiy wrote: > > > > Currently, qemuxml2argvmock.c only mocks virNumaNodeIsAvailable(), and > > only if libvirt was built with NUMA support. This causes some test > > failures where NUMA is

Re: [libvirt] [PATCH] qemuxml2argvtest: uncoditionally mock NUMA routines

2016-05-13 Thread Ján Tomko
On Thu, May 12, 2016 at 10:47:04AM +0300, Roman Bogorodskiy wrote: > Currently, qemuxml2argvmock.c only mocks virNumaNodeIsAvailable(), and > only if libvirt was built with NUMA support. This causes some test > failures where NUMA is involved. > This is misleading, you are probably compiling with

[libvirt] [PATCH] qemuxml2argvtest: uncoditionally mock NUMA routines

2016-05-12 Thread Roman Bogorodskiy
Currently, qemuxml2argvmock.c only mocks virNumaNodeIsAvailable(), and only if libvirt was built with NUMA support. This causes some test failures where NUMA is involved. For example, memory-hotplug-dimm fails because it goes all they way down to qemuBuildMemoryBackendStr() that calls virNumaNodes