Re: [libvirt] [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE

2019-07-04 Thread Daniel P . Berrangé
On Thu, Jul 04, 2019 at 09:28:01AM +0200, Peter Krempa wrote: > On Thu, Jul 04, 2019 at 08:16:21 +0200, Fabiano Fidêncio wrote: > > 86fbce56f27e removed the constant, but didn't actually adjust the only > > place where the constant was used. > > > > Signed-off-by: Fabiano Fidêncio > > --- > > Thi

Re: [libvirt] [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE

2019-07-04 Thread Fabiano Fidêncio
On Thu, Jul 4, 2019 at 9:28 AM Peter Krempa wrote: > > On Thu, Jul 04, 2019 at 08:16:21 +0200, Fabiano Fidêncio wrote: > > 86fbce56f27e removed the constant, but didn't actually adjust the only > > place where the constant was used. > > > > Signed-off-by: Fabiano Fidêncio > > --- > > This patch f

Re: [libvirt] [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE

2019-07-04 Thread Peter Krempa
On Thu, Jul 04, 2019 at 08:16:21 +0200, Fabiano Fidêncio wrote: > 86fbce56f27e removed the constant, but didn't actually adjust the only > place where the constant was used. > > Signed-off-by: Fabiano Fidêncio > --- > This patch fixes a build breakage. > > It's either this, or reverting 86fbce56

Re: [libvirt] [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE

2019-07-03 Thread Boris Fiuczynski
This patch is sort of incomplete since the unprivileged usage path still shows the default path for the configuration file that this patch would remove for the privileged path. I think the simplest solution is to revert 86fbce56f27e. On 7/4/19 8:16 AM, Fabiano Fidêncio wrote: 86fbce56f27e remo

Re: [libvirt] [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE

2019-07-03 Thread Bjoern Walk
Fabiano Fidêncio [2019-07-04, 08:16AM +0200]: > 86fbce56f27e removed the constant, but didn't actually adjust the only > place where the constant was used. > > Signed-off-by: Fabiano Fidêncio > --- > This patch fixes a build breakage. > > It's either this, or reverting 86fbce56f27e. > --- > sr

[libvirt] [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE

2019-07-03 Thread Fabiano Fidêncio
86fbce56f27e removed the constant, but didn't actually adjust the only place where the constant was used. Signed-off-by: Fabiano Fidêncio --- This patch fixes a build breakage. It's either this, or reverting 86fbce56f27e. --- src/remote/remote_daemon.c | 4 1 file changed, 4 deletions(-)