Re: [libvirt] [PATCH] rpc: Fix client crash when server drops connection

2013-03-27 Thread Jiri Denemark
On Tue, Mar 26, 2013 at 10:17:01 -0600, Eric Blake wrote: > On 03/26/2013 09:52 AM, Jiri Denemark wrote: > > Despite of the comment stating virNetClientIncomingEvent handler should > > s/of // > > > never be called with either client->haveTheBuck or client->wantClose > > set, there is a sequence

Re: [libvirt] [PATCH] rpc: Fix client crash when server drops connection

2013-03-26 Thread Eric Blake
On 03/26/2013 09:52 AM, Jiri Denemark wrote: > Despite of the comment stating virNetClientIncomingEvent handler should s/of // > never be called with either client->haveTheBuck or client->wantClose > set, there is a sequence of events that may lead to both booleans being > true when virNetClientI

[libvirt] [PATCH] rpc: Fix client crash when server drops connection

2013-03-26 Thread Jiri Denemark
Despite of the comment stating virNetClientIncomingEvent handler should never be called with either client->haveTheBuck or client->wantClose set, there is a sequence of events that may lead to both booleans being true when virNetClientIncomingEvent is called. However, when that happens, we must not