Re: [libvirt] [PATCH] snapshot: allow reuse of existing files in disk snapshot

2012-01-10 Thread Eric Blake
On 01/10/2012 10:15 AM, Peter Krempa wrote: > On 01/09/2012 08:03 PM, Eric Blake wrote: >> When disk snapshots were first implemented, libvirt blindly refused >> to allow an external snapshot destination that already exists, since >> qemu will blindly overwrite the contents of that file during the

Re: [libvirt] [PATCH] snapshot: allow reuse of existing files in disk snapshot

2012-01-10 Thread Peter Krempa
On 01/09/2012 08:03 PM, Eric Blake wrote: When disk snapshots were first implemented, libvirt blindly refused to allow an external snapshot destination that already exists, since qemu will blindly overwrite the contents of that file during the snapshot_blkdev monitor command, and we don't like a

[libvirt] [PATCH] snapshot: allow reuse of existing files in disk snapshot

2012-01-09 Thread Eric Blake
When disk snapshots were first implemented, libvirt blindly refused to allow an external snapshot destination that already exists, since qemu will blindly overwrite the contents of that file during the snapshot_blkdev monitor command, and we don't like a default of data loss by default. But VDSM h