Re: [libvirt] [PATCH] snapshot: require user to supply external memory file name

2012-11-16 Thread Eric Blake
On 11/15/2012 09:53 PM, Osier Yang wrote: > On 2012年11月16日 08:49, Eric Blake wrote: >> For disk snapshots, the user could request an external snapshot >> but not supply a filename; later on, we would check this condition >> and generate a suitable name if possible, or gracefully error out >> when n

Re: [libvirt] [PATCH] snapshot: require user to supply external memory file name

2012-11-15 Thread Osier Yang
On 2012年11月16日 08:49, Eric Blake wrote: For disk snapshots, the user could request an external snapshot but not supply a filename; later on, we would check this condition and generate a suitable name if possible, or gracefully error out when not possible (such as when the original file was a bloc

[libvirt] [PATCH] snapshot: require user to supply external memory file name

2012-11-15 Thread Eric Blake
For disk snapshots, the user could request an external snapshot but not supply a filename; later on, we would check this condition and generate a suitable name if possible, or gracefully error out when not possible (such as when the original file was a block device). But unless we come up with a s