Re: [libvirt] [PATCH] storage: Fix mention of disk pool default

2018-08-30 Thread John Ferlan
On 08/30/2018 10:04 AM, Eric Blake wrote: > On 08/30/2018 08:41 AM, John Ferlan wrote: > >> >> "dos" is the expected value; however, "msdos" is >> the value used by "parted mklabel --script msdos" (see >> virStorageBackendDiskBuildPool) >> >> So that line in the storage page for the Disk pool d

Re: [libvirt] [PATCH] storage: Fix mention of disk pool default

2018-08-30 Thread Eric Blake
On 08/30/2018 08:41 AM, John Ferlan wrote: "dos" is the expected value; however, "msdos" is the value used by "parted mklabel --script msdos" (see virStorageBackendDiskBuildPool) So that line in the storage page for the Disk pool description isn't entirely wrong, but it is somewhat misleading

Re: [libvirt] [PATCH] storage: Fix mention of disk pool default

2018-08-30 Thread John Ferlan
On 08/29/2018 06:22 PM, Eric Blake wrote: > The default disk storage pool type is 'dos', not 'msdos'. > > Signed-off-by: Eric Blake > --- > > I ran into this doc bug when trying to figure out why a disk storage > pool that I had copied from another machine wouldn't autostart; it > turns out t

[libvirt] [PATCH] storage: Fix mention of disk pool default

2018-08-29 Thread Eric Blake
The default disk storage pool type is 'dos', not 'msdos'. Signed-off-by: Eric Blake --- I ran into this doc bug when trying to figure out why a disk storage pool that I had copied from another machine wouldn't autostart; it turns out that the old disk used BIOS partitioning (dos), and the new on