Re: [libvirt] [PATCH] tests/networkxml2conf: Fix to work again on non-Linux

2016-12-23 Thread Martin Kletzander
On Fri, Dec 23, 2016 at 11:12:37AM +0100, Andrea Bolognani wrote: On Fri, 2016-12-23 at 10:45 +0100, Martin Kletzander wrote: > if (virAsprintf(&inxml, "%s/networkxml2confdata/%s.xml", > abs_srcdir, info->name) < 0 || > -virAsprintf(&outxml, "%s/networkxml2confdat

Re: [libvirt] [PATCH] tests/networkxml2conf: Fix to work again on non-Linux

2016-12-23 Thread Andrea Bolognani
On Fri, 2016-12-23 at 10:45 +0100, Martin Kletzander wrote: > > if (virAsprintf(&inxml, "%s/networkxml2confdata/%s.xml", > > abs_srcdir, info->name) < 0 || > > -virAsprintf(&outxml, "%s/networkxml2confdata/%s.conf", > > -abs_srcdir, info->name) <

Re: [libvirt] [PATCH] tests/networkxml2conf: Fix to work again on non-Linux

2016-12-23 Thread Martin Kletzander
On Thu, Dec 22, 2016 at 08:43:33PM +0100, Andrea Bolognani wrote: Since commit 478ddedc12b7 the name of the loopback interface in the generated dnsmasq configuration is OS-dependent. However, the test suite has not been updated to cope with the change, causing it to fail on FreeBSD and other non-

[libvirt] [PATCH] tests/networkxml2conf: Fix to work again on non-Linux

2016-12-22 Thread Andrea Bolognani
Since commit 478ddedc12b7 the name of the loopback interface in the generated dnsmasq configuration is OS-dependent. However, the test suite has not been updated to cope with the change, causing it to fail on FreeBSD and other non-Linux operating systems. Modify the networkxml2conf test case to re