Re: [libvirt] [PATCH] tests: Add DO_TEST_PARSE_ERROR() to qemuxml2xml

2017-07-10 Thread Andrea Bolognani
On Fri, 2017-07-07 at 13:15 +0200, Peter Krempa wrote: > > that is to, in due time, make it so you only need to list > > input file and capabilities once to have them tested both > > for xml2argv and xml2xml, and this is a step towards that > > still pretty far away goal. >  > This is certainly a g

Re: [libvirt] [PATCH] tests: Add DO_TEST_PARSE_ERROR() to qemuxml2xml

2017-07-07 Thread Peter Krempa
On Fri, Jul 07, 2017 at 13:00:10 +0200, Andrea Bolognani wrote: > On Fri, 2017-07-07 at 12:48 +0200, Peter Krempa wrote: > > > qemuxml2argv already supports the ability to include test > > > cases that are known not to make it past > XML parsing, and > > > since we want to keep qemuxml2xml in sync

Re: [libvirt] [PATCH] tests: Add DO_TEST_PARSE_ERROR() to qemuxml2xml

2017-07-07 Thread Andrea Bolognani
On Fri, 2017-07-07 at 12:48 +0200, Peter Krempa wrote: > > qemuxml2argv already supports the ability to include test > > cases that are known not to make it past XML parsing, and > > since we want to keep qemuxml2xml in sync with it as much > > as possible, we need to implement this missing feature

Re: [libvirt] [PATCH] tests: Add DO_TEST_PARSE_ERROR() to qemuxml2xml

2017-07-07 Thread Peter Krempa
On Tue, Jul 04, 2017 at 15:13:51 +0200, Andrea Bolognani wrote: > qemuxml2argv already supports the ability to include test > cases that are known not to make it past XML parsing, and > since we want to keep qemuxml2xml in sync with it as much > as possible, we need to implement this missing featur

[libvirt] [PATCH] tests: Add DO_TEST_PARSE_ERROR() to qemuxml2xml

2017-07-04 Thread Andrea Bolognani
qemuxml2argv already supports the ability to include test cases that are known not to make it past XML parsing, and since we want to keep qemuxml2xml in sync with it as much as possible, we need to implement this missing feature. Signed-off-by: Andrea Bolognani --- tests/qemuxml2xmltest.c | 104