Re: [libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-14 Thread Eric Blake
On 05/14/2011 02:32 AM, Matthias Bolte wrote: >>> +ignore_value(virAsprintf(&def->name, "%ld", (long)tv.tv_sec)); >> >> Ouch. Cygwin is thinking of making time_t a 64-bit entity, but since >> cygwin is 32-bit, that's larger than long. >> >> We need to use %lld and (long long) instead (or %

Re: [libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake : > On 05/12/2011 11:53 PM, Matthias Bolte wrote: >> --- >>  src/conf/domain_conf.c |    6 +++--- >>  1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c >> index d3efec6..875f90e 100644 >> --- a/src/conf/domain_co

Re: [libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-13 Thread Eric Blake
On 05/12/2011 11:53 PM, Matthias Bolte wrote: > --- > src/conf/domain_conf.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index d3efec6..875f90e 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_co

Re: [libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2011 at 07:53:29AM +0200, Matthias Bolte wrote: > --- > src/conf/domain_conf.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index d3efec6..875f90e 100644 > --- a/src/conf/domain_conf.c > +++ b/

[libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

2011-05-12 Thread Matthias Bolte
--- src/conf/domain_conf.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d3efec6..875f90e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9115,7 +9115,7 @@ virDomainSnapshotDefPtr virDomainS