Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-28 Thread Boris Fiuczynski
On 2/27/19 10:48 AM, Thomas Huth wrote: On 27/02/2019 10.15, Bjoern Walk wrote: With further testing... Thomas Huth [2019-02-26, 12:02PM +0100]: When running virt-host-validate on an s390x host, the tool currently warns that it is "Unknown if this platform has IOMMU support". We can use the c

Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-27 Thread Ján Tomko
On Tue, Feb 26, 2019 at 12:02:20PM +0100, Thomas Huth wrote: When running virt-host-validate on an s390x host, the tool currently warns that it is "Unknown if this platform has IOMMU support". We can use the common check for entries in sys/kernel/iommu_groups here, too, but it only makes sense to

Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-27 Thread Boris Fiuczynski
On 2/27/19 9:12 AM, Thomas Huth wrote: On 27/02/2019 09.07, Boris Fiuczynski wrote: Besides the minor required change below Reviewed-by: Boris Fiuczynski Thanks for catching this On 2/26/19 12:02 PM, Thomas Huth wrote: When running virt-host-validate on an s390x host, the tool currently warn

Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-27 Thread Thomas Huth
On 27/02/2019 10.15, Bjoern Walk wrote: > With further testing... > > Thomas Huth [2019-02-26, 12:02PM +0100]: >> When running virt-host-validate on an s390x host, the tool currently >> warns that it is "Unknown if this platform has IOMMU support". >> We can use the common check for entries in sy

Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-27 Thread Bjoern Walk
With further testing... Thomas Huth [2019-02-26, 12:02PM +0100]: > When running virt-host-validate on an s390x host, the tool currently > warns that it is "Unknown if this platform has IOMMU support". > We can use the common check for entries in sys/kernel/iommu_groups here, > too, but it only ma

Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-27 Thread Thomas Huth
On 27/02/2019 09.07, Boris Fiuczynski wrote: > Besides the minor required change below > Reviewed-by: Boris Fiuczynski > > Thanks for catching this > > On 2/26/19 12:02 PM, Thomas Huth wrote: >> When running virt-host-validate on an s390x host, the tool currently >> warns that it is "Unknown if

Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-27 Thread Boris Fiuczynski
Besides the minor required change below Reviewed-by: Boris Fiuczynski Thanks for catching this On 2/26/19 12:02 PM, Thomas Huth wrote: When running virt-host-validate on an s390x host, the tool currently warns that it is "Unknown if this platform has IOMMU support". We can use the common check

Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-26 Thread Bjoern Walk
Thomas Huth [2019-02-26, 12:02PM +0100]: > When running virt-host-validate on an s390x host, the tool currently > warns that it is "Unknown if this platform has IOMMU support". > We can use the common check for entries in sys/kernel/iommu_groups here, > too, but it only makes sense to check it if

[libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-26 Thread Thomas Huth
When running virt-host-validate on an s390x host, the tool currently warns that it is "Unknown if this platform has IOMMU support". We can use the common check for entries in sys/kernel/iommu_groups here, too, but it only makes sense to check it if there are also PCI devices available. It's also co