Re: [libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

2016-04-08 Thread Andrea Bolognani
On Fri, 2016-04-08 at 14:17 +0200, Peter Krempa wrote: > > doesn't 'addr' need to be checked as well? > > 'addr' is declared as ATTRIBUTE_NONNULL. Also it wasn't touched by that > patch so I don't thinkso. Right, never mind then. > > I'd like to have all of these fixed in a single patch, but > >

Re: [libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

2016-04-08 Thread Andrea Bolognani
On Fri, 2016-04-08 at 13:55 +0200, Peter Krempa wrote: > VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL > into virNetDevSetIPAddress it crashes. Regression introduced by > b3d069872ce53eb. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325120 > --- >  src/util/vir

Re: [libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

2016-04-08 Thread Peter Krempa
On Fri, Apr 08, 2016 at 14:11:00 +0200, Andrea Bolognani wrote: > On Fri, 2016-04-08 at 13:55 +0200, Peter Krempa wrote: > > VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL > > into virNetDevSetIPAddress it crashes. Regression introduced by > > b3d069872ce53eb. > > > > Resolve

Re: [libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

2016-04-08 Thread Vasiliy Tolstov
2016-04-08 14:55 GMT+03:00 Peter Krempa : > VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL > into virNetDevSetIPAddress it crashes. Regression introduced by > b3d069872ce53eb. My fail, thanks! -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru -- libvir-list mailing list lib

[libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL

2016-04-08 Thread Peter Krempa
VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL into virNetDevSetIPAddress it crashes. Regression introduced by b3d069872ce53eb. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325120 --- src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff