Re: [libvirt] [PATCH] util: netdevbridge: fall back to ioctl from sysfs

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 01:03:09PM +0100, Christian Ehrhardt wrote: > On Tue, Nov 20, 2018 at 12:58 PM Daniel P. Berrangé > wrote: > > > > On Tue, Nov 20, 2018 at 11:17:07AM +0100, Christian Ehrhardt wrote: > > > There are certain cases e.g. containers where the sysfs path might > > > exists, but

Re: [libvirt] [PATCH] util: netdevbridge: fall back to ioctl from sysfs

2018-11-20 Thread Christian Ehrhardt
On Tue, Nov 20, 2018 at 12:58 PM Daniel P. Berrangé wrote: > > On Tue, Nov 20, 2018 at 11:17:07AM +0100, Christian Ehrhardt wrote: > > There are certain cases e.g. containers where the sysfs path might > > exists, but might fail. Unfortunately the exact restrictions are only > > known to libvirt w

Re: [libvirt] [PATCH] util: netdevbridge: fall back to ioctl from sysfs

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 11:17:07AM +0100, Christian Ehrhardt wrote: > There are certain cases e.g. containers where the sysfs path might > exists, but might fail. Unfortunately the exact restrictions are only > known to libvirt when trying to write to it so we need to try it. > > But in case it fa

Re: [libvirt] [PATCH] util: netdevbridge: fall back to ioctl from sysfs

2018-11-20 Thread Christian Ehrhardt
On Tue, Nov 20, 2018 at 11:17 AM Christian Ehrhardt wrote: > > There are certain cases e.g. containers where the sysfs path might > exists, but might fail. Unfortunately the exact restrictions are only > known to libvirt when trying to write to it so we need to try it. > > But in case it fails the

[libvirt] [PATCH] util: netdevbridge: fall back to ioctl from sysfs

2018-11-20 Thread Christian Ehrhardt
There are certain cases e.g. containers where the sysfs path might exists, but might fail. Unfortunately the exact restrictions are only known to libvirt when trying to write to it so we need to try it. But in case it fails there is no need to fully abort, in those cases try to fall back to the ol