Re: [libvirt] [PATCH] util: refactor iptables command construction into multiple steps

2012-12-03 Thread Natanael Copa
On Thu, 22 Nov 2012 15:02:18 +0100 Natanael Copa wrote: > Instead of creating an iptables command in one shot, do it in steps > so we can add conditional options like physdev and protocol. > > This removes code duplication while keeping existing behaviour. > > Signed-off-by: Natanael Copa > --

Re: [libvirt] [PATCH] util: refactor iptables command construction into multiple steps

2012-11-22 Thread Natanael Copa
On Thu, 22 Nov 2012 15:02:18 +0100 Natanael Copa wrote: > Instead of creating an iptables command in one shot, do it in steps > so we can add conditional options like physdev and protocol. > > This removes code duplication while keeping existing behaviour. > > Signed-off-by: Natanael Copa > --

[libvirt] [PATCH] util: refactor iptables command construction into multiple steps

2012-11-22 Thread Natanael Copa
Instead of creating an iptables command in one shot, do it in steps so we can add conditional options like physdev and protocol. This removes code duplication while keeping existing behaviour. Signed-off-by: Natanael Copa --- This started with me wanting to add support for setting the public ip