Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Eric Blake
On 10/24/2014 10:17 AM, Shanzhi Yu wrote: > >>> >>> if (networkDriver && virRegisterNetworkDriver(networkDriver) < 0) >> ACK to this. >> >>> Or did you botch the logic, and really mean: >>> >>> if (!networkDriver || virRegisterNetworkDriver(networkDriver) < 0) >>> >>> Furthermore, Dan's recent pa

Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Shanzhi Yu
On 10/24/2014 10:52 PM, Daniel P. Berrange wrote: On Fri, Oct 24, 2014 at 08:47:47AM -0600, Eric Blake wrote: On 10/24/2014 03:31 AM, Shanzhi Yu wrote: libvirtd will report below error if does not make sure driver not be NULL in virRegisterNetworkDriver $ libvirtd 2014-10-24 09:24:36.443+

Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 08:47:47AM -0600, Eric Blake wrote: > On 10/24/2014 03:31 AM, Shanzhi Yu wrote: > > libvirtd will report below error if does not make sure driver not be NULL > > in virRegisterNetworkDriver > > > > $ libvirtd > > 2014-10-24 09:24:36.443+: 28876: info : libvirt version:

Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Eric Blake
On 10/24/2014 03:31 AM, Shanzhi Yu wrote: > libvirtd will report below error if does not make sure driver not be NULL > in virRegisterNetworkDriver > > $ libvirtd > 2014-10-24 09:24:36.443+: 28876: info : libvirt version: 1.2.10 > 2014-10-24 09:24:36.443+: 28876: error : virRegisterNetwork

[libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Shanzhi Yu
libvirtd will report below error if does not make sure driver not be NULL in virRegisterNetworkDriver $ libvirtd 2014-10-24 09:24:36.443+: 28876: info : libvirt version: 1.2.10 2014-10-24 09:24:36.443+: 28876: error : virRegisterNetworkDriver:549 : driver in virRegisterNetworkDriver must